Prepare for handling uncompressed Gossip MessageId #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch is created by pluggable messageFactory. messageFactory replaces messageIdGenerator because of PubsubMessage.messageId property
…uals/hashCode absence
…e which is capable of handling PubsubMessage.messageId in a lazy fashion
# Conflicts: # src/main/kotlin/io/libp2p/pubsub/AbstractRouter.kt # src/main/kotlin/io/libp2p/pubsub/PubsubMessageValidator.kt # src/main/kotlin/io/libp2p/pubsub/PubsubRouter.kt # src/main/kotlin/io/libp2p/pubsub/gossip/MCache.kt
Nashatyrev
changed the title
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Libp2p Gossip to make it possible for Teku to calculate Gossip
message-idbased on uncompressed payload content and allow to:message-idcalculation, second on message handling)message-id(which need duplicate uncompressing) for duplicate inbound messages: by usingfast-message-id(id based on compressed content)The first is achieved by introducing a
PubsubMessagewrapper class instead of the raw protobufRpc.MessageandAbstractRouter.messageFactoryby which the client code may create his ownPubsubMessageimplementation with necessary caching of uncompressed payloadThe second is achieved by changing
AbstractRouter.seenMessagesto a pluggable custom 'Map-like'SeenCacheinterface withFastIdSeenCacheimplementationRelated Teku PR: Consensys/teku#3188