Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire readComplete() event to Stream channels #181

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fire readComplete() event to Stream channels #181

merged 1 commit into from
Feb 25, 2021

Conversation

Nashatyrev
Copy link
Collaborator

It turned out that readComplete events are not propagated to child Stream channels and this caused ReadTimeoutHandler to behave incorrectly: it just didn't throw TimeoutException if at least one byte was read.

The idea is to propagate the Connection readComplete event to those Streams which were reading after the previous readComplete and are not yet closed.

ajsutton
ajsutton approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Nashatyrev Nashatyrev merged commit ed2a5f3 into libp2p:develop Feb 25, 2021
@Nashatyrev Nashatyrev deleted the fix/fire-read-complete-to-stream branch August 16, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashatyrev @ajsutton