Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of Mplex fixes #205

Merged
merged 7 commits into from
Dec 21, 2021
Merged

A couple of Mplex fixes #205

merged 7 commits into from
Dec 21, 2021

Conversation

Nashatyrev
Copy link
Collaborator

  • Check mplex frame length prior to reading all frame content. If the length exceeds max bound then discard remaining data and close connection
  • Slice outbound data if it exceeds max mplex frame data length (worth to be fixed in the light of increased message size limit up to 10Mb in the Merge fork)

ajsutton
ajsutton approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ajsutton ajsutton merged commit 8110434 into libp2p:develop Dec 21, 2021
@Nashatyrev Nashatyrev mentioned this pull request Feb 1, 2022
Merged
@Nashatyrev Nashatyrev deleted the fix/mplex-fixes branch February 2, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashatyrev @ajsutton