Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remote PeerId check on dial #215

Merged
merged 11 commits into from
Jan 24, 2022
Merged

Fix remote PeerId check on dial #215

merged 11 commits into from
Jan 24, 2022

Conversation

Nashatyrev
Copy link
Collaborator

  • Some Multiaddr class refactorings
  • Verify remote PeerId on connect

@Nashatyrev
Refactor Multiaddr. Add a couple of tests
1cba96c
@Nashatyrev
Verify that expected remote peerId matches Noise handshake peerId whe…
d8e75e2 
…n initiating connection
@Nashatyrev
Adjust Network.connect(PeerId, Multiaddr) implementation to include s…
2423954 
…upplied PeerId to the resulting Multiaddr
@Nashatyrev
Adjust GoInteropTest to run and connect daemon with an identity
ab4617b
@Nashatyrev
Add remotePeerId to the TestChannel
22b0300
@Nashatyrev
Adjust the TwoGossipHostTestBase to supply remote peerId when connect…
14ca87d 
…ing other host
@Nashatyrev
Adjust test to check for p2p multiaddr component insted of ipfs
7b3af94
@Nashatyrev
Rename method Multiaddr.withPeerId() to withP2P() to avoid ambiguity
3327ece
@Nashatyrev
More Multiaddr refactoring: replace toPeerIdAndAddr() with getPeerId(…
82ff0df 
…) which checks either `/ipfs/` or `/p2p/` component for the PeerId
@Nashatyrev
Fix MultiaddrDns: Multiaddr components should be just concatenated no…
a184b90 
…t merged
@Nashatyrev
Formatting
85a8054
ajsutton
ajsutton approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ajsutton ajsutton merged commit 60153d1 into libp2p:develop Jan 24, 2022
@Nashatyrev Nashatyrev deleted the fix/remote-id-check branch February 2, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashatyrev @ajsutton