Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GossipParam tests and fix a few small issues #232

Merged
merged 7 commits into from
Mar 7, 2022
Merged

Add GossipParam tests and fix a few small issues #232

merged 7 commits into from
Mar 7, 2022

Commits on Mar 3, 2022

  1. Fix some gossip param error messages 

    * For gossipFactor, there was a range mismatch.
* For graylistThreshold, the message said "gossipThreshold" instead.
* The others checked >= or <= but the message said > or <.
    @jtraglia
    jtraglia committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    d7dd621 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Revert graylistThreshold error msg & add tests 

    Right now I've only added gossip score tests. I will add other tests next;
those should be easier.
    @jtraglia
    jtraglia committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    c81563f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'libp2p:develop' into fix-error-message

    @jtraglia
    jtraglia authored Mar 4, 2022
    Configuration menu
    Copy the full SHA
    f12ef1a View commit details
    Browse the repository at this point in the history

  3. Add some GossipParams tests 

    Also added check to make sure these values are >= 0.

Also modified graylistThreshold error message to better match other messages.
    @jtraglia
    jtraglia committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    16c28a6 View commit details
    Browse the repository at this point in the history

  4. Add some more GossipParams tests

    @jtraglia
    jtraglia committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    784e999 View commit details
    Browse the repository at this point in the history

  5. Add GossipPeerScoreParams tests

    @jtraglia
    jtraglia committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    4eb086f View commit details
    Browse the repository at this point in the history

  6. Add GossipTopicScoreParams tests

    @jtraglia
    jtraglia committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    1be39e2 View commit details
    Browse the repository at this point in the history