Optimization: no need to instantiate SecureRandom on sign() calls #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Jul 14, 2022
| import org.bouncycastle.asn1.ASN1Primitive | ||
| import org.bouncycastle.asn1.ASN1Sequence | ||
| import org.bouncycastle.asn1.DERSequenceGenerator | ||
| import org.bouncycastle.asn1.* |
There was a problem hiding this comment.
Do we use * imports normally? I'm not overly fussed just checking.
There was a problem hiding this comment.
Yep, it's kind of historically:
kotlinter {
disabledRules = arrayOf("no-wildcard-imports")
}
Tried to remove this line. The formatter was unable to fix this automatically. So leaving this 'as is' for now. Have no strong preference of this or that option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Secp256k1PrivateKey.sign()instantiatesSecureRandomon every call.It's obsolete, as BouncyCastle uses it's own
SecureRandomsingleton when not supplied one.