Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JMH benchmark #253

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Conversation

Nashatyrev
Copy link
Collaborator

Generally introduces the ability to add JMH benchmarks

For that:

  • extract testFixtures module from the test module.
  • add jmh source set and jmh build target (similar to the Teku gradle build)
  • make jmh module depending on testFixtures
  • add a sample GossipScoreBenchmark benchmark.

The benchmark is in Java since JMH doesn't work well with Kotlin. Tried the kotlinx-benchmark suite, but unfortunately it doesn't work with existing JMH IDEA plugin

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Nashatyrev Nashatyrev merged commit c3bef5d into libp2p:develop Aug 16, 2022
@Nashatyrev Nashatyrev deleted the optimization/jmh-benchamrks branch August 16, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants