-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Android example #275
Merged
Nashatyrev
merged 19 commits into
libp2p:v1.0.0
from
Nashatyrev:feature/integrate-android-example
May 17, 2023
Merged
Integrate Android example #275
Nashatyrev
merged 19 commits into
libp2p:v1.0.0
from
Nashatyrev:feature/integrate-android-example
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rid of printed exception during build)
…ere. It doesn't work in other minimalistic sample project
…r in settings.gradle
StefanBratanov
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of #272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Android example to the gradle build to ensure jvm-Libp2p is interoperable with Android SDK:
8.0
android.useAndroidX
property to the rootgradle.properties
(for some reason defining this property in the Android submodule doesn't work)libp2p.gradle.custom
per project property which indicates whether common gradle code for submodules should be skipped (set it up for Adnroid example)settings.gradle
settings.gradle
detect if Android SDK is installed and conditionally include:examples:android-chatter
moduleANDROID_HOME
is definedsdk.dir
property is defined inlocal.properties
file (created by AndroidStudio)Setup Android SDK
GitHub actionAs a result:
ANDROID_HOME
is defined, Android example is build by the gradlelocal.properties
file is automatically created), the Android example module is included and can be executedFix #270