Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: test fixtures sort. Regression bug fix #284

Merged
merged 2 commits into from
May 25, 2023
Merged

Refactor: test fixtures sort. Regression bug fix #284

merged 2 commits into from
May 25, 2023

Conversation

Nashatyrev
Copy link
Collaborator

This PR contains 2 unrelated items:

  • Refactor tests: move all utility test classes to the testFixtures module. Sort out corresponding dependencies
  • Fix regression introduced in Yamux implementation #281: the MplexFrame should implement ReferenceCounted interface to get released by Netty internals.
    • Add unit test reproducing the issue

rolfyone
rolfyone approved these changes May 25, 2023
View reviewed changes
Copy link

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashatyrev Nashatyrev merged commit 63869ca into libp2p:v1.0.0 May 25, 2023
@Nashatyrev Nashatyrev mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashatyrev @rolfyone