Fix ecdsa cert usage in TLS which bouncycastle broke #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianopolous
force-pushed
the
fix/tls-ecdsa-bouncycastle
branch
from
2a09315
to
847a36c
Compare
Change unit test to cover this
ianopolous
force-pushed
the
fix/tls-ecdsa-bouncycastle
branch
from
847a36c
to
c649bad
Compare
Add TlsSecureChannel::ECDSA builder
ianopolous
force-pushed
the
fix/tls-ecdsa-bouncycastle
branch
from
55dfb5b
to
48bf987
Compare
Nashatyrev
approved these changes
Jun 8, 2023
libp2p/src/main/kotlin/io/libp2p/security/tls/TLSSecureChannel.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Nashatyrev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update unit test to cover this
Edit: Including another fix for early muxer negotiation via ALPN which wasn't actually using the ALPN result.
Added a helper method to construct ECDSA based instances of TLS.