Refactor Yamux flags #338
Merged
Refactor Yamux flags #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ByteBufQueue tests * Writing exec path is always through fill/drain buffer * Adopt/fix existing tests * Add new test checking correct handling of negative sendWindowSize
… for write (due to zero sendWindow)
…ffered-write # Conflicts: # libp2p/src/main/kotlin/io/libp2p/mux/yamux/YamuxHandler.kt
StefanBratanov
approved these changes
Oct 11, 2023
| @@ -9,17 +8,15 @@ import io.netty.buffer.Unpooled | |||
| /** | |||
| * Contains the fields that comprise a yamux frame. | |||
| * @param id the ID of the stream. | |||
| * @param flags the flags value for this frame. | |||
| * @param flag the flag for this frame. | |||
There was a problem hiding this comment.
should be flags right?
# Conflicts: # libp2p/src/main/kotlin/io/libp2p/mux/yamux/YamuxHandler.kt # libp2p/src/test/kotlin/io/libp2p/mux/yamux/YamuxHandlerTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based atop of #330)
YamuxTypeto enum: e088393YamuxFlags: convert them toSetofenumvalues. While the Yamux spec doesn't seem to allow a flags bitmask with more than one flag set it looks better to treat that explicitly as a 'set of flags': e28efd5