Implement autonat protocol #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty fine with it, assuming there are just new classes added. |
|
(Next up will be dcutr and integrating all these into RelayTransport) |
|
LGTM to me as well |
ianopolous
force-pushed
the
feat/autonat
branch
from
0c29fdd
to
c90732f
Compare
|
Tests were green before the rebase off develop. Are they flakey? |
|
This is good to merge now. |
|
@Nashatyrev Any chance of merging this? We have downstream work that depends on it. |
Just did. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Nashatyrev Any thoughts on this?