-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm-ext: Replace libp2p-wasm-ext
with libp2p-websocket-websys
#3611
Comments
Honestly, I dont see a downside to migrating over to websys since it would be less code (eg js) to maintain. |
I don't have much experience with either. Off the top of my head this sounds like the right step forward. |
@vincev Would you be up for contributing your transport to the mono repo? |
@thomaseizinger sure no problem, how can I help? |
Really, all there is to do is deleting the existing If that works for you, it'd be great if you could send a PR! |
Sounds good, I'll create a PR in the next few days. |
How do I add you as owners? I tried the following but I am getting an error: cargo owner -v --list libp2p
Updating crates.io index
tomaka (Pierre Krieger)
mxinden (Max Inden)
github:paritytech:core-devs (Core devs)
github:paritytech:libp2p-devs (Libp2p devs)
github:libp2p:repos-rust (Repos - Rust)
github:libp2p:rust-libp2p-maintainers (rust-libp2p Maintainers) and then when I try to add maintainers I get: cargo owner --add github:libp2p:rust-libp2p-maintainers
Updating crates.io index
error: failed to invite owners to crate `libp2p-websys-transport` on registry at https://crates.io
Caused by:
the remote server responded with an error: could not find the github team libp2p/rust-libp2p-maintainers |
I am not sure about the exact syntax. @mxinden Can you help? |
libp2p-wasm-ext
?libp2p-wasm-ext
with libp2p-websys-transport
Not sure whether this is still an issue.
My first guess would be that you can only add a GitHub group in case you are part of that group. Would that make sense? |
Yes makes sense, but you are right we don't need to do this anymore as you now own |
libp2p-wasm-ext
with libp2p-websys-transport
libp2p-wasm-ext
with libp2p-websocket-websys
@vincev built a pure Rust websys-based websocket transport here: https://github.com/vincev/libp2p-websys-transport
We currently offer something similar in https://github.com/libp2p/rust-libp2p/tree/master/transports/wasm-ext but involves Javascript.
The
libp2p-wasm-ext
transport is a bit more capable because it allows arbitrary transports to be plugged in. In reality, you can only usewebsocket
though. Both WebRTC and WebTransport are not possible because they have a built-in security protocol and multiplexer.@mxinden Should we retire our
libp2p-wasm-ext
module in favor of one withwebsys
bindings?The text was updated successfully, but these errors were encountered: