Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of ConnectionHandlerEvent::Close from libp2p_relay #4716

Closed
thomaseizinger opened this issue Oct 24, 2023 · 0 comments · Fixed by #4718
Closed

Remove usage of ConnectionHandlerEvent::Close from libp2p_relay #4716

thomaseizinger opened this issue Oct 24, 2023 · 0 comments · Fixed by #4718
Assignees
@thomaseizinger

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Oct 24, 2023 •
edited
Loading

As part of #3591 we need to stop closing connections upon errors on individual streams.
This was referenced Oct 24, 2023
Closed
Merged
@thomaseizinger thomaseizinger self-assigned this Oct 24, 2023
@mergify mergify bot closed this as completed in #4718 Nov 1, 2023
mergify bot pushed a commit that referenced this issue Nov 1, 2023
@thomaseizinger
feat(relay): don't close connections upon errors in relay server
823d0b2 
To remove the usages of `ConnectionHandlerEvent::Close` from the relay-server, we unify what used to be called `CircuitFailedReason` and `FatalUpgradeError`. Whilst the errors may be fatal for the particular circuit, they are not necessarily fatal for the entire connection.

Related: #3591.
Resolves: #4716.

Pull-Request: #4718.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomaseizinger thomaseizinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(relay): don't close connections upon errors in relay server libp2p/rust-libp2p
1 participant
@thomaseizinger