[Kademlia] Rehash PeerId before inserting in a KBucketsTable #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 25, 2019 17:49
* Document * Move impl
ghost
assigned 
tomaka
suggested changes
Mar 25, 2019
protocols/kad/src/kbucket.rs
Outdated
| } | ||
|
|
||
| fn max_distance() -> NonZeroUsize { | ||
| <Multihash as KBucketsPeerId>::max_distance() |
There was a problem hiding this comment.
If we change the hash to a [u8; 32], then that should be 256, and distance_with adjusted accordingly.
There was a problem hiding this comment.
I have changed this as well. I think we could abstract the xor metric away, but I'm missing a trait for .leading_zeros() in U512 and U256. What do you think?
There was a problem hiding this comment.
Also for the case where we compare KadHash and Multihash I have taken max_distance to be 512 and converted both hashes to U512.
There was a problem hiding this comment.
I think we should split distance_with and max_distance in two different traits, something like:
trait MaxDistance: DistanceWith<Self> {
fn max_distance() -> u32;
}
trait DistanceWith<TOther> {
fn distance_with(&self, other: &TOther) -> u32;
}There was a problem hiding this comment.
I would make that a new PR
tomaka
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use
PeerIddirectly as a key into a Kademlia table because it happens to be a hash of the address of a peer. However, the reference implementation uses a hash of the hash. This PR introduces a new struct,KadHashthat is to be used instead as key.There are actually two use cases for
PeerId: as key into the Kademlia table and as an actual identifier of a peer.KadHashsupports both by storing thePeerIdand the new hash together.Function
Kademlia::initialize()has become obsolete and has been removed.Function
Kademlia::without_init()has been marked deprecated.This PR includes minor fixes for warnings.
Addresses: #694