Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update async-std to 1.6.2 #1618

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Jun 19, 2020

(still testing, will mark as ready when I am confident it is working)

Ref #1612

@dignifiedquire dignifiedquire marked this pull request as ready for review June 21, 2020 19:25
@dignifiedquire
Copy link
Member Author

dignifiedquire commented Jun 21, 2020

Ready for review, all tests are now passing out of the box, thanks to the diligent work from @stjepang

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @dignifiedquire @stjepang for the help!

As I have not been very involved in #1588 I will leave it up to the rest to approve.

Its a bummer that we can't just ignore 1.6.0 and 1.6.1 (See rust-lang/cargo#5286), but given that 1.5.0 and 1.6.2 are within the same major version I doubt any downstream dependency would complain being forced to update.

@tomaka
Copy link
Member

tomaka commented Jun 22, 2020

I'm trying this on Polkadot and it seems to work so far. 🚀

@tomaka
Copy link
Member

tomaka commented Jun 22, 2020

I'm still going to test more, but I think it's ok to merge this.
I think we should wait for a couple days (during which a node will be running with this PR) to put it in a release of libp2p though.

@twittner
Copy link
Contributor

Then we should wait with the merge until we have published the new libp2p version which will require async-std 1.5.0. If we merge this now we would use 1.6.2 as a lower bound.

@tomaka
Copy link
Member

tomaka commented Jun 22, 2020

It's been running for 4 hours now, and there isn't any anomaly in sight.

@tomaka
Copy link
Member

tomaka commented Jun 24, 2020

Still no anomaly, everything running smoothly.
Let's merge this?

@romanb romanb merged commit 823c747 into libp2p:master Jun 29, 2020
@dignifiedquire dignifiedquire deleted the upgrade-async-std branch June 29, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants