sim open #2099
Closed
sim open #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the multistream-select 1.0 simultaneous open protocol extension specification: > In order to support direct connections through NATs with hole punching, we need to account for simultaneous open. In such cases, there is no single initiator and responder, but instead both peers act as initiators. This breaks protocol negotiation in multistream-select, which assumes a single initator. > This draft proposes a simple extension to the multistream protocol negotiation in order to select a single initator when both peers are acting as such. See libp2p/specs#196 for details. This commit implements the above specification, available via `Version::V1SimOpen`.
rkuhn
reviewed
Jun 9, 2021
| @@ -238,7 +290,7 @@ impl<R> MessageIO<R> { | |||
| MessageReader { inner: self.inner.into_reader() } | |||
| } | |||
|
|
|||
| /// Drops the [`MessageIO`] resource, yielding the underlying I/O stream. | |||
| /// Draops the [`MessageIO`] resource, yielding the underlying I/O stream. | |||
|
@mxinden do you have a timeline for when you expect this feature to be merged? |
I am not sure what you are referring to with "this feature". In case you are referring to the solution suggested in this pull request: I don't think we should merge it as (a) it is adding more complexity in general and (b) it is polluting the function signature for stream upgrades which will never need this functionality. In case you are referring to support for multistream-select simultaneous open in general: I don't know, especially as it depends on so many other efforts (e.g. circuit relay v2, direct connection upgrade through relay, ...). See #2066 (comment) for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the failing test case in #2066