Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/muxing: Remove the StreamMuxer::flush_all function #2669

Merged

Conversation

thomaseizinger
Copy link
Contributor

Description

libp2p-core provides the StreamMuxer abstraction so it can provide
functionality that abstracts over this trait.

We never use the flush_all function as part of our abstractions.
No one else is going to use it so we can remove it from the abstraction.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

`libp2p-core` provides the `StreamMuxer` abstraction so it can provide
functionality that abstracts over this trait.

We never use the `flush_all` function as part of our abstractions.
No one else is going to use it so we can remove it from the abstraction.
@thomaseizinger thomaseizinger changed the title Remove the StreamMuxer::flush_all function core/muxing: Remove the StreamMuxer::flush_all function May 23, 2022
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mxinden mxinden merged commit 2b79f11 into libp2p:master May 29, 2022
@kpp kpp mentioned this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants