Refactor Yamux::close to use ?
#2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
mxinden
reviewed
May 29, 2022
muxers/yamux/src/lib.rs
Outdated
| Some(Ok(_)) => {} // drop inbound stream | ||
| Some(Err(e)) => return Poll::Ready(Err(e)), | ||
|
|
||
| while let Poll::Ready(_inbound_stream) = |
There was a problem hiding this comment.
Suggested change
| while let Poll::Ready(_inbound_stream) = | |
| while let Poll::Ready(inbound_stream) = |
Why prefix inbound_stream with an _?
There was a problem hiding this comment.
To make it more obvious that it will be unused but I guess technically it is not unused!
There was a problem hiding this comment.
I've tried to improve this with 6eb64fe.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Hopefully) improves readability of the implementation due to reduced noise.
Links to any relevant issues
Extracted out of #2648.
Open Questions
Change checklist