-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/muxing: Force StreamMuxer::Substream
to implement Async{Read,Write}
#2707
Merged
Commits on Jun 20, 2022
-
core/muxing: Introduce
SubstreamBox
which implements `Async{Read,Wr……ite}` Instead of delegating reading and writing of the substream to the `StreamMuxer`, we introduce a `SubstreamBox` which implements `Async{Read,Write}`. This is used as the `Substream` associated type in `StreamMuxerBox`. This allows us to delete the `read_substream` etc functions from the `StreamMuxer` trait.
Configuration menu - View commit details
-
Copy full SHA for 50f703f - Browse repository at this point
Copy the full SHA 50f703fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8db3eef - Browse repository at this point
Copy the full SHA 8db3eefView commit details -
Configuration menu - View commit details
-
Copy full SHA for f014c29 - Browse repository at this point
Copy the full SHA f014c29View commit details -
These are already implied through the associated type.
Configuration menu - View commit details
-
Copy full SHA for 09fcb44 - Browse repository at this point
Copy the full SHA 09fcb44View commit details -
Configuration menu - View commit details
-
Copy full SHA for ceed232 - Browse repository at this point
Copy the full SHA ceed232View commit details
Commits on Jun 22, 2022
-
Update core/src/muxing/boxed.rs
Co-authored-by: Max Inden <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6597a54 - Browse repository at this point
Copy the full SHA 6597a54View commit details -
Configuration menu - View commit details
-
Copy full SHA for e52ea08 - Browse repository at this point
Copy the full SHA e52ea08View commit details -
Configuration menu - View commit details
-
Copy full SHA for e23b3f2 - Browse repository at this point
Copy the full SHA e23b3f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 310d391 - Browse repository at this point
Copy the full SHA 310d391View commit details
Commits on Jun 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e980e38 - Browse repository at this point
Copy the full SHA e980e38View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.