feat(kademlia)!: use GATs on RecordStore trait
#3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
changed the title
RecordStore traitRecordStore trait
This was referenced Dec 14, 2022
4 tasks
|
Friendly ping @mxinden :) |
|
This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏 |
4 tasks
mxinden
approved these changes
Dec 22, 2022
Comment on lines
+67
to
+73
| pub trait RecordStore { | ||
| type RecordsIter<'a>: Iterator<Item = Cow<'a, Record>> | ||
| where | ||
| Self: 'a; | ||
| type ProvidedIter<'a>: Iterator<Item = Cow<'a, ProviderRecord>> | ||
| where | ||
| Self: 'a; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we applied a lifetime onto the entire
RecordStoreto workaround Rust not having GATs. With Rust 1.65.0 we now have GATs so we can remove this workaround.Related #3240. Without this change, we would have to specify HRTB in various places.
Notes
Depends-On: libp2p/test-plans#90
Links to any relevant issues
Open Questions
Change checklist