Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(request-response): don't close connection on stream errors #3913

Merged
merged 6 commits into from
May 15, 2023
Merged

feat(request-response): don't close connection on stream errors #3913

merged 6 commits into from
May 15, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Related: #3591.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mergify

This comment was marked as resolved.

Sign in to view
mxinden
mxinden approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify mergify bot merged commit 1742bff into master May 15, 2023
@mergify mergify bot deleted the refactor/req-res-no-close-connection branch May 15, 2023 02:40
@thomaseizinger thomaseizinger mentioned this pull request May 23, 2023
Closed
@oblique oblique mentioned this pull request Oct 6, 2023
Closed
alindima pushed a commit to alindima/rust-libp2p that referenced this pull request Jan 9, 2024
@thomaseizinger @alindima
feat(request-response): don't close connection on stream errors
85e3025 
Related: libp2p#3591.

Pull-Request: libp2p#3913.
@alindima alindima mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden