Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(quic): prepare v0.9.0-alpha #4262

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Jul 28, 2023

Description

Notes & open questions

@kpp @thomaseizinger any objections?

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@dariusc93
Copy link
Member

I am excited to see how this performs compared to the previous implementation, although shouldnt it be 0.9.0-alpha.0 instead?

@thomaseizinger
Copy link
Contributor

I am excited to see how this performs compared to the previous implementation, although shouldnt it be 0.9.0-alpha.0 instead?

See https://github.com/libp2p/rust-libp2p/blob/master/docs/release.md#dealing-with-alphas.

@thomaseizinger
Copy link
Contributor

I am excited to see how this performs compared to the previous implementation, although shouldnt it be 0.9.0-alpha.0 instead?

See master/docs/release.md#dealing-with-alphas.

One could argue that this change is non-breaking but given that it is essentially a re-write, I think it is better to release it as a breaking change to make the update an explicit yet effortless action.

@thomaseizinger
Copy link
Contributor

No objection. What is the plan forward for removing the alpha status of QUIC?

@mxinden
Copy link
Member Author

mxinden commented Jul 31, 2023

I am excited to see how this performs compared to the previous implementation, although shouldnt it be 0.9.0-alpha.0 instead?

Numbers on https://observablehq.com/@libp2p-workspace/performance-dashboard look very promising (see rust-libp2p-quinn) @dariusc93.

@mxinden
Copy link
Member Author

mxinden commented Jul 31, 2023

What is the plan forward for removing the alpha status of QUIC?

We have multiple outstanding bugs:

I would have to give the above bugs a bit more thought. Though I am leaning towards releasing v0.9.0 (without -alpha), in case no major bugs are found in v0.9.0-alpha.

@mxinden mxinden added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Jul 31, 2023
@mergify mergify bot merged commit 3af3d5d into libp2p:master Jul 31, 2023
63 of 64 checks passed
@mxinden
Copy link
Member Author

mxinden commented Jul 31, 2023

Tagged and published.

thomaseizinger pushed a commit that referenced this pull request Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants