Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add taple to notable users #4309

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

yerayrodriguez
Copy link
Contributor

@yerayrodriguez yerayrodriguez commented Aug 9, 2023

Description

Request to add TAPLE Project to rust-libp2p notable users. TAPLE is a permissioned DLT solution for traceability of assets and processes. We use libp2p for the network layer.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

mxinden
mxinden previously approved these changes Aug 17, 2023
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see another user.

@yerayrodriguez
Copy link
Contributor Author

yerayrodriguez commented Aug 17, 2023

Great to see another user.

Thanks @mxinden .
The PR is out-of-date. I'm not sure if I have to update the branch with merge or rebase, since the 'send-it' label is already applied.

@thomaseizinger
Copy link
Contributor

Great to see another user.

Thanks @mxinden . The PR is out-of-date. I'm not sure if I have to update the branch with merge or rebase, since the 'send-it' label is already applied.

No need for any action :)
See https://github.com/libp2p/rust-libp2p/blob/master/CONTRIBUTING.md#merging-of-prs-is-automated.

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2023

This pull request has merge conflicts. Could you please resolve them @yerayrodriguez? 🙏

@mergify mergify bot dismissed mxinden’s stale review August 18, 2023 19:25

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit ffdd812 into libp2p:master Aug 18, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants