-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kad)!: add ModeChanged
event
#4341
Closed
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9467159
feat!: added kademlia ModeChanged event
dhuseby f81207f
bumped crate version
dhuseby fb61697
deps(identity): update ed25519-dalek to 2.0
jxs 16b2f15
chore: use workspace `rust-version`
mxinden 08292c5
docs: remove archived `ursa` project from README
p-shahi bf7fe68
refactor(tcp): reducing branching in `Transport::create_socket`
jxs ffdd812
docs(readme): add taple to notable users
yerayrodriguez d3da24f
deps: bump pin-project from 1.1.2 to 1.1.3
dependabot[bot] 2dbfc8e
Update protocols/kad/CHANGELOG.md
dhuseby 88766cf
Update protocols/kad/CHANGELOG.md
dhuseby 7da6ff6
Update protocols/kad/src/behaviour.rs
dhuseby 251783f
feat!: added kademlia ModeChanged event
dhuseby b34b96e
rebasing
dhuseby 664c97d
Update protocols/kad/CHANGELOG.md
dhuseby 9377401
Update protocols/kad/CHANGELOG.md
dhuseby 4fb3e52
Update protocols/kad/src/behaviour.rs
dhuseby 57fa234
event only emits when mode changes automatically
dhuseby 53cc23a
catching up with GH suggested changes
dhuseby 10ea2d7
pulling in GH merges messed things up a bit
dhuseby 42b1be5
fix the broken tests
dhuseby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something seems to have gone wrong during the rebase / merge because this diff is showing up here as if it were in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah...I think I pulled the upstream master into my branch at some point. let me see if I can clean this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to do an interactive rebase and drop the unwanted commits and they don't show up in the list of available commits to drop. So instead I created a new branch and used cherry-pick to recreate this PR's branch with just my commits and your review commits. The new branch is here: https://github.com/dhuseby/rust-libp2p/tree/add-kad-modechanged-event
I was think the best course of action at this point is to close this PR and file a new PR with the new clean branch. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sounds good!