noise: remove interface definition #452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface exposed by a libp2p Noise implementation is highly implementation-specific. Really, there’s no reason to even suggest something like
SecureInbound
andSecureOutbound
, there are other ways to implement (and name) this that are equally conformant with this spec and interoperable with other implementations.More importantly, the references made to early data in this section directly contradict what we’re planning to do with early data for WebTransport (#404), WebRTC (#412) and muxer negotiation (#446).