Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: Add test vectors for TLS spec #464

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Sep 30, 2022

cc @marten-seemann

Fixes #459.

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test added in libp2p/go-libp2p#1788.

@marten-seemann marten-seemann changed the title tls: Add test vectors for TLs spec tls: Add test vectors for TLS spec Oct 3, 2022
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomaseizinger!

Pinging maintainers of other implementations, may be helpful for them as well. @Menduist @Nashatyrev @btoms20 @achingbrain

tls/tls.md Outdated Show resolved Hide resolved
tls/tls.md Outdated Show resolved Hide resolved
@mxinden mxinden merged commit 106b4ad into libp2p:master Oct 4, 2022
@thomaseizinger thomaseizinger deleted the 459-tls-test-vectors branch October 4, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include test vectors in specifications
3 participants