Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify config file #81

Closed
hrj opened this issue Apr 12, 2021 · 1 comment · Fixed by #92
Closed

Ability to specify config file #81

hrj opened this issue Apr 12, 2021 · 1 comment · Fixed by #92
Assignees
Milestone

Comments

@hrj
Copy link
Contributor

hrj commented Apr 12, 2021

It should be possible to specify a different path for the config file from the command line.

Hence, Config should be converted to a class, which takes file path as a constructor parameters.

@hrj hrj added this to the version 1.1 milestone Apr 12, 2021
@hrj
Copy link
Contributor Author

hrj commented Apr 24, 2021

  1. The user can specify the config path on the command line. For now, the first argument on the command line can be the config file path.
  2. The default path for a config file, when not specified on command line, is data/config.json
  3. If a file doesn't exist at the config path, a default one is created at that path, and read back as the current config
  1. and 3. are already done, only 1. needs to be implemented

@rr83019 This plan is a little different from what we discussed. The change to in-memory database can be done separately later. Trying to keep the changes to a minimal for now.

@rr83019 rr83019 self-assigned this Apr 25, 2021
@hrj hrj closed this as completed in #92 May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants