-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make config parameters optional #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Rudragoudar <[email protected]>
rr83019
force-pushed
the
opt-config-param
branch
from
January 7, 2022 20:29
26e7883
to
425065a
Compare
Signed-off-by: Rahul Rudragoudar <[email protected]>
Signed-off-by: Rahul Rudragoudar <[email protected]>
rr83019
force-pushed
the
opt-config-param
branch
from
January 7, 2022 20:46
f61698b
to
fabd5dd
Compare
hrj
reviewed
Jan 8, 2022
Signed-off-by: Rahul Rudragoudar <[email protected]>
I was able to get it to work after some trial and error: When using Option for extraction, we need to use java types instead of scala types. So this works: case class ConfigField(
port: Option[Integer],
address: Option[String],
throttle: Option[Integer],
seed: Option[Integer],
captchaExpiryTimeLimit: Option[Integer],
threadDelay: Option[Integer],
boolTest: Option[java.lang.Boolean],
corsHeader: Option[String],
maxAttempts: Option[Integer]
) Needs to be converted to the correct Scala type later. So I did this hack: case class ConfigField(
port: Option[Integer],
address: Option[String],
throttle: Option[Integer],
seed: Option[Integer],
captchaExpiryTimeLimit: Option[Integer],
threadDelay: Option[Integer],
boolTest: Option[java.lang.Boolean],
corsHeader: Option[String],
maxAttempts: Option[Integer]
) {
val portInt = port.map(_ + 0)
val boolTestBoolean = boolTest.map(_ || true)
}
...
val fields = configJson.extract[ConfigField]
val port1: Int = fields.portInt.getOrElse(8888)
val address1: String = fields.address.getOrElse("0.0.0.0")
val boolTest: Boolean = fields.boolTestBoolean.getOrElse(true)
|
Signed-off-by: Rahul Rudragoudar <[email protected]>
Signed-off-by: Rahul Rudragoudar <[email protected]>
hrj
requested changes
Jan 9, 2022
Signed-off-by: Rahul Rudragoudar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #105