Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #220 appimage build script #226

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

JocelynDelalande
Copy link
Collaborator

Fix #220

That is a first step, that allow building AppImages locally.

If that looks good, I'd suggest that we build and upload (maybe using GH workflows ?) AppImage automatically

  • an appimage on every push to develop (continuous build)
  • an appimage on every PR (to allow power-users to beta-test stuff)

… And we should definitely start building AppImages for releases, but maybe manually, to allow further control and testing… and cryptographic signature (GPG).

@JocelynDelalande JocelynDelalande changed the title Fix #220 appimage buid script Fix #220 appimage build script May 9, 2020
@JocelynDelalande JocelynDelalande marked this pull request as draft May 9, 2020 22:52
@JocelynDelalande
Copy link
Collaborator Author

JocelynDelalande commented May 9, 2020

This is a draft as it needs further testing on different distros on my side. But you can help me testing and toy around with that first AppImage I made with this PR (two files are the same, one of those being GPG-signed, the other not).

https://nuage.delalande.fr/s/TdDsYfsTMBxT9QC

It won't overwrite your existing LIbreOsteo installation and data. It will use a new data (database and upload directory) within ~/.local/share/libreosteo

to start playing :

⚠️ For now : use it for testing, not for managing actual data ! ⚠️

  • download the file
  • (verify and extract it if you choosen the .gpg file)
  • make the .AppImage executable
  • run it !

- appstream
- .desktop
- icon suitable for freedesktop standard
Builds an executable standalone archive for current working copy.

For now, this has to be triggered manually, but we may in near future want to :

- trigger a build + upload on any commit on develop
- trigger a build + upload for tagged releases

Fix libreosteo#220
On subsequent runs, do not start anything but rather open web browser on LO
URL.

Ref libreosteo#220
@JocelynDelalande JocelynDelalande marked this pull request as ready for review September 17, 2020 13:50
@JocelynDelalande JocelynDelalande marked this pull request as draft September 17, 2020 13:50
@JocelynDelalande
Copy link
Collaborator Author

@jbgury would it be possible to make the PR tested against travis, as I am trying stuff on travis ? (or maybe allow me to push to unprotected branches on libreosteo/Libreosteo repo ?)

@JocelynDelalande JocelynDelalande force-pushed the jd-fix-220-appimage-develop branch 7 times, most recently from 8078de7 to 023fcc6 Compare September 17, 2020 16:31
@JocelynDelalande
Copy link
Collaborator Author

@jbgury j'ai l'erreur suivante pour les tests fonctionnels :

Tests.Core.001 Register User                                                  

==============================================================================

First Installation :: Register an administrator on freshed install... | FAIL |

WebDriverException: Message: Reached error page: about:neterror?e=connectionFailure&u=http%3A//localhost%3A8085/&c=UTF-8&d=Firefox%20ne%20peut%20%C3%A9tablir%20de%20connexion%20avec%20le%20serveur%20%C3%A0%20l%E2%80%99adresse%20localhost%3A8085.

Je ne vois pas trop ce que j'ai changé qui puisse casser ça. Une idée ?
source : https://travis-ci.com/github/libreosteo/Libreosteo/jobs/386400617

@JocelynDelalande JocelynDelalande force-pushed the jd-fix-220-appimage-develop branch 9 times, most recently from da53316 to 028d4ca Compare September 18, 2020 08:41
@JocelynDelalande JocelynDelalande force-pushed the jd-fix-220-appimage-develop branch 5 times, most recently from d3aa454 to 929f342 Compare September 18, 2020 09:25
@jbgury
Copy link
Contributor

jbgury commented Sep 21, 2020

Tu n'as plus le problème visiblement

@JocelynDelalande
Copy link
Collaborator Author

Oui, je ne sais pas trop si ça tient à quelque-chose que tu aurais fait ou au fait que moi j'ai configuré la CI sur mon fork. En tout cas c'est OK pour tester.

@jbgury jbgury marked this pull request as ready for review October 22, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants