Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert speedtest.js, speedtest_worker.js to ES6 with JSDoc comments #359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SCG82
Copy link
Contributor

@SCG82 SCG82 commented Sep 26, 2020

No description provided.

@Perflyst
Copy link
Collaborator

As far as I can see this would drop Internet Explorer support, right?

@adolfintel
Copy link
Member

Yes, it would break IE11 support. I'm also not familiar with the newer revisions of JavaScript so it would make it difficult for me to maintain.

I appreciate your work but I can't merge this one yet

@SCG82
Copy link
Contributor Author

SCG82 commented Sep 26, 2020

Perfectly understood.

@bt90
Copy link
Contributor

bt90 commented Jul 14, 2022

Microsoft has pulled the plug on IE. This should no longer be an obstacle.

@SCG82
Copy link
Contributor Author

SCG82 commented Jul 14, 2022

@adolfintel Any interest in merging this (after conflicts are resolved)?

@adolfintel
Copy link
Member

@SCG82 I would be interested but I really need someone to maintain this project because I'm working full time and I don't have time to deal with something so large at the moment.

Copy link
Contributor

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants