-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new frontend implementing fromScratch design #649
base: master
Are you sure you want to change the base?
Conversation
Well, this definitely looks better than the old one. Thanks for your work. The only change I'd make would be using the official logo and maybe redesign the server selection box a bit, right now I think the text is a bit huge and doesn't have enough line spacing. I think this should be the new UI for 6.0, when we'll drop support for old stuff like IE11. What do you think @sstidl ? |
It looks modern and a little freaky but I like it. Haven't been able to test it yet |
Thank you @adolfintel for your support!! Regarding the changes you suggested, we are planning to add them to this year's Hacktoberfest event as a task for the design participants. |
I started a new branch with the new design named Can someone change the behaviour so that there is no server-list.json the local server is used and no selection box is shown? |
@Timendus can you try to rebase your PR to the new newdesign branch and have a look over it? |
I think I just managed to. Let me know if it's not so. I can't really judge the Dockerfiles, looks fine to me, but I'm not a regular user of Docker.
When the list in |
Hey there! I hope you like pull requests from random strangers bearing gifts :)
I had a couple of days of free time, and I came across the design by fromScratch in #585. I thought it looked great, and that it deserved a good implementation, so I set out to make one.
I've taken the liberty of changing a couple of details, coming up with some animations and adding a few small features, but otherwise I've tried to stay as close to the "intention" of the design as I could.
If you want to take it out for a spin, I'm hosting the frontend here (at least for a little while):
http://vps.timendus.com/speedtest
(Note that it doesn't currently show the "share" feature nor the popup with privacy information because I haven't configured my server to store anything. It's configurable though.)
To use on your own server, just copy'n'paste everything in
frontend
to the project root (just like the other examples, only a few more files).Reasons to merge this PR
server-list.json
speedtest_worker.js
settings throughsettings.json
Reasons NOT to accept this PR
Other notes
Hope you like it! And thanks for a great Open Source project!