fix: kmsdrm: Use drmModeAddFB2WithModifiers instead of drmModeAddFB #10117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using GBM modifiers. This fixes corrupt framebuffers on platforms that require the use of modifiers.
|
This generally seems good. We may need a dual path with the new symbol being optional, but if not, this patch looks good as-is. |
|
Merged, thanks! |
|
This seems to require libgbm >= 17.1.0, you should document this (and possibly change configurators.) (EDIT: libdrm version requirement possibly needs updating too -- to what, I don't know, though.) |
|
Thanks, good point, I was expecting something needed to be bumped. Not sure how to approach from here though. |
|
Seems to have been added to libdrm >= 2.4.71: https://gitlab.freedesktop.org/mesa/drm/-/commit/abfa680dbdfa4600105d904f4903c047d453cdb5 in 2016. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes corrupt framebuffers on platforms that require the use of modifiers such as NVIDIA Tegra, as noted in #10107.
Description
There are three different variants of the
drmModeAddFBcall:drmModeAddFB,drmModeAddFB2anddrmModeAddFB2WithModifiers. SDL currently uses the first variant but this results in framebuffer corruption as can be seen in #10107. This changes that call to use the modifiers supplied by libgbm, which seem to be required on platforms such as NVIDIA Tegra.Existing Issue(s)
#10107