Drag Enter & Drag Exit #10435
Draft
Drag Enter & Drag Exit #10435
+93
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TheZitroX
reviewed
Nov 3, 2024
src/video/x11/SDL_x11events.c
Outdated
| @@ -1346,7 +1346,7 @@ static void X11_DispatchEvent(SDL_VideoDevice *_this, XEvent *xevent) | |||
| data->xdnd_req = X11_PickTargetFromAtoms(display, xevent->xclient.data.l[2], xevent->xclient.data.l[3], xevent->xclient.data.l[4]); | |||
| } | |||
| } | |||
| else if (xevent.xclient.message_type == videodata->XdndLeave) { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides Drag Enter and Drag Exit events for files being dragged
I'm opening this as a draft until Windows support is added
Description
This adds the events:
SDL_EVENT_DRAG_ENTER
SDL_EVENT_DRAG_EXIT
The current supported platforms are:
Linux X11
Linux Wayland (TODO: testing needed)
MacOS
Planned platforms:
Windows (Requires #10415)
There are currently no errors on building for any platform when running it through Github Workflows
This code was originally coded for SDL2 so some style updates to the code might need to be done.