macos: Added SDL_macOSSetAnimationCallback. #10549
Open
+145
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icculus
force-pushed
the
sdl3-macos-anim-callback
branch
5 times, most recently
from
9e9b5db
to
91855fb
Compare
This was originally @grimaldini's work, in libsdl-org#9720, but I've rebased it against the latest, added documentation, and cleaned up some small things.
icculus
force-pushed
the
sdl3-macos-anim-callback
branch
from
91855fb
to
6a67ef5
Compare
|
Ugh, okay, this is actually messier than I thought: CADisplayLink (the originally-iOS interface) is available in macOS 14.0+, which is why the original PR worked on the arm64 builder but not the Intel one...we'd have to use CVDisplayLink for older macOS releases, which is a totally different thing. I'd still like to have this, but I'm going to bump it from the milestone; we can add it later if using the older interface is workable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally @grimaldini's work, in #9720, but I've rebased it against the latest, added documentation, and cleaned up some small things.
I need to actually test this on a Mac still, so this is in a PR for now.