Add APIs to query joystick/gamecontroller rumble support #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When API limitations force us to guess, we favor a false positive (reporting support when it doesn't exist) compared to a false negative.
meyerj
added a commit
to meyerj/joystick_drivers
that referenced
this pull request
Oct 19, 2023
SDL_GameControllerHasRumble() was introduced in SDL 2.0.18 only (libsdl-org/SDL#4943). Signed-off-by: Johannes Meyer <[email protected]>
clalancette
pushed a commit
to ros-drivers/joystick_drivers
that referenced
this pull request
Oct 23, 2023
SDL_GameControllerHasRumble() was introduced in SDL 2.0.18 only (libsdl-org/SDL#4943). Signed-off-by: Johannes Meyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
SDL_JoystickHasRumble(),SDL_JoystickHasRumbleTriggers(),SDL_GameControllerHasRumble(), andSDL_GameControllerHasRumbleTriggers()to allow applications to query what types of rumble are supported by a given joystick/gamecontroller.To make this (and other similar changes in the future) easier, I converted
HasLED()to a more genericGetCapabilities()function which returns LED, rumble, and trigger rumble capabilities.Along with being useful for applications, these APIs also allow us to implement virtual
SDL_Hapticsupport on top ofSDL_Joystickfor backwards compatibility with code using the legacy haptics API.