Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of bound array access in src_linear.c #208

Open
lkoenig opened this issue Mar 6, 2024 · 2 comments
Open

Out of bound array access in src_linear.c #208

lkoenig opened this issue Mar 6, 2024 · 2 comments
Labels
bug

Comments

@lkoenig
Copy link

lkoenig commented Mar 6, 2024

In some particular cases, src_linear.c perform an access on the input array with an index of -1 in https://github.com/libsndfile/libsamplerate/blob/master/src/src_linear.c#L122 when priv->in_used is 0 because.

I'll add a PR with a test case catching this corner case.
lkoenig added a commit to lkoenig/libsamplerate that referenced this issue Mar 6, 2024
@lkoenig
Add test to catch out of bound array access.
b956d1e 
This is to repro a bug reported in libsndfile#208
@lkoenig lkoenig mentioned this issue Mar 6, 2024
Open
lkoenig added a commit to lkoenig/libsamplerate that referenced this issue Mar 6, 2024
@lkoenig
Add test to catch out of bound array access.
99589c6 
This is to repro a bug reported in libsndfile#208
lkoenig added a commit to lkoenig/libsamplerate that referenced this issue Mar 7, 2024
@lkoenig
Fix out of bound access in src_linear
ed6e7e2 
Fix libsndfile#208 about out of bount access in linear resampler.

Also migrates to count the sumber of frames instead of the number of
samples and remove some redundant member of the private state.

Signed-off-by: Lionel Koenig Gélas <[email protected]>
lkoenig added a commit to lkoenig/libsamplerate that referenced this issue Mar 7, 2024
@lkoenig
Fix out of bound access in src_linear
8e62284 
Fix libsndfile#208 about out of bount access in linear resampler.

Also migrates to count the sumber of frames instead of the number of
samples and remove some redundant member of the private state.

Signed-off-by: Lionel Koenig Gélas <[email protected]>
@evpobr
Copy link
Member

evpobr commented May 11, 2024

Hi @lkoenig

@evpobr evpobr added the bug label May 11, 2024
@lkoenig
Copy link
Author

lkoenig commented May 13, 2024

Hi @evpobr :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkoenig @evpobr