Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type in PEM+SSH decoder #670

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix type in PEM+SSH decoder #670

merged 1 commit into from
Oct 7, 2024

Conversation

sjaeckel
Copy link
Member

@sjaeckel sjaeckel commented Oct 3, 2024

9b6bf32 changed the type of the length argument of a LTC_SSHDATA_STRING from ulong32 to unsigned long and usage of this wrong type survived multiple re-factors and code moves.

This fixes #669

@karel-m
Copy link
Member

karel-m commented Oct 6, 2024

I have a confirmation from debian guys that this fix works.

@sjaeckel
Copy link
Member Author

sjaeckel commented Oct 6, 2024

I have a confirmation from debian guys that this fix works.

The following comment comes from DCIT/perl-CryptX#111 (comment)

@gregoa could you please try CryptX-0.081_001?

I haven't been able to find CryptX-0.081_001. Where can I see that release?

The last comment by @gregoa in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1082952 and the issue resolution tells me that we can't conclude that this PR has been tested, since the official bug resolution still includes the patch by Niko Tyni.

@sjaeckel
Copy link
Member Author

sjaeckel commented Oct 6, 2024

FTR: some relevant links to the debian packages etc.

Package: https://packages.debian.org/sid/libcryptx-perl
Patches of 0.081-2: https://sources.debian.org/patches/libcryptx-perl/0.081-2/

@karel-m
Copy link
Member

karel-m commented Oct 6, 2024

DCIT/perl-CryptX#111 (comment)

https://metacpan.org/release/MIK/CryptX-0.081_001

9b6bf32 changed the type of the length
argument of a `LTC_SSHDATA_STRING` from `ulong32` to `unsigned long` and
usage of this wrong type survived multiple re-factors and code moves.

This fixes #669

Signed-off-by: Steffen Jaeckel <[email protected]>
@sjaeckel
Copy link
Member Author

sjaeckel commented Oct 7, 2024

DCIT/perl-CryptX#111 (comment)

https://metacpan.org/release/MIK/CryptX-0.081_001

Thanks! After having a third look on the metacpan page I also found out where I can find that development release 🤦

Sorry for the noise.

@sjaeckel sjaeckel merged commit 29af892 into develop Oct 7, 2024
75 checks passed
@sjaeckel sjaeckel deleted the fix-669 branch October 7, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pem_decode_openssh troubles on architectures: s390x, ppc64, sparc64, x32
3 participants