Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify scripts #293

Merged
merged 8 commits into from
May 27, 2019
Merged

Simplify scripts #293

merged 8 commits into from
May 27, 2019

Conversation

minad
Copy link
Member

@minad minad commented May 24, 2019

  • remove updatemakes
  • start to remove dep.pl (should be part of helper.pl)
  • dep.pl is now part of helper.pl

@minad minad changed the title Simplify scripts [WIP] Simplify scripts May 24, 2019
@minad minad changed the title [WIP] Simplify scripts Simplify scripts May 24, 2019
@minad minad requested a review from sjaeckel May 24, 2019 10:41
@minad
Copy link
Member Author

minad commented May 24, 2019

@sjaeckel I hope we can avoid adding new scripts and put all the generation tasks inside helper.pl. dep.pl is a legacy script which is now also part of helper.pl. I transformed everything carefully in a few steps, so there should be no breakage.

@sjaeckel
Copy link
Member

there's one thing that breaks... no ./updatemakes.sh -c anymore ;)

@minad
Copy link
Member Author

minad commented May 24, 2019

there's one thing that breaks... no ./updatemakes.sh -c anymore ;)

Yes, that's intentional. I think it is better if the scripts don't mess with git and I never used this. Agree?

@minad
Copy link
Member Author

minad commented May 24, 2019

Haha, the git log agrees with me.

$ git log --oneline | grep 'Update makefiles$' | wc
0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants