-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port CI and CMake support from develop #573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
* copy GitHub actions from develop * copy testme.sh from develop Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
(cherry picked from commit f993147)
sjaeckel
force-pushed
the
port-from-develop
branch
2 times, most recently
from
March 14, 2024 08:45
17a088d
to
96f09ef
Compare
* there's no c89-c99 rountrip support on master * there's no proper symbol hiding on master * amalgamation works differently on master Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
force-pushed
the
port-from-develop
branch
from
March 14, 2024 08:53
f7721ef
to
d4a322d
Compare
Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
force-pushed
the
port-from-develop
branch
from
March 14, 2024 09:06
ece40da
to
c81d069
Compare
czurnieden
approved these changes
Mar 15, 2024
There was something about building for Android with some MS pack where lack of cmake in master was a problem. Do you, just by chance, remember what Issue # that was to check if it works now? |
Yeah, that was #523, right? |
Ah, yes, that one, thanks! We'll only know for sure if it works when all the cmake stuff is in master, so I'll say: we'll pass that bridge when we reach it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for GitHub Actions and CMake from the develop branch.
Let's include this in the next (and hopefully last 1.x) release of master.
This fixes #556