Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port CI and CMake support from develop #573

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Port CI and CMake support from develop #573

merged 6 commits into from
Mar 19, 2024

Conversation

sjaeckel
Copy link
Member

@sjaeckel sjaeckel commented Mar 14, 2024

Add support for GitHub Actions and CMake from the develop branch.

Let's include this in the next (and hopefully last 1.x) release of master.

This fixes #556

@sjaeckel sjaeckel linked an issue Mar 14, 2024 that may be closed by this pull request
sjaeckel and others added 3 commits March 14, 2024 09:40
* copy GitHub actions from develop
* copy testme.sh from develop

Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
(cherry picked from commit f993147)
@sjaeckel sjaeckel force-pushed the port-from-develop branch 2 times, most recently from 17a088d to 96f09ef Compare March 14, 2024 08:45
* there's no c89-c99 rountrip support on master
* there's no proper symbol hiding on master
* amalgamation works differently on master

Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
@czurnieden
Copy link
Contributor

There was something about building for Android with some MS pack where lack of cmake in master was a problem. Do you, just by chance, remember what Issue # that was to check if it works now?

@sjaeckel
Copy link
Member Author

Yeah, that was #523, right?

@czurnieden
Copy link
Contributor

Yeah, that was #523, right?

Ah, yes, that one, thanks!

We'll only know for sure if it works when all the cmake stuff is in master, so I'll say: we'll pass that bridge when we reach it.

@sjaeckel sjaeckel linked an issue Mar 19, 2024 that may be closed by this pull request
@sjaeckel sjaeckel merged commit a1baa97 into master Mar 19, 2024
@sjaeckel sjaeckel deleted the port-from-develop branch March 19, 2024 14:04
@sjaeckel sjaeckel added this to the v1.3.0 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake Library can not be used in android (arm64)
3 participants