Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up all .pm and .t #203

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yoshikazusawa
Copy link
Contributor

8dc5646 I applied perltidy to all .pm and .t files in accordance with "Code style and tidying" in CONTRIBUTING.md.
b6d8da0 Also made some manual adjustments to tab characters in comments.

3bcaa63 Additionally, fix small path correction in CONTRIBUTING.md.

@oalders
Copy link
Member

oalders commented Oct 30, 2024

Thanks for this, @yoshikazusawa! I would love to tidy the entire distribution, but I think this would make it harder to merge (or even review) the existing pull requests. There is a note about that in the README section that you linked to:

as this is an old distribution and styling has changed somewhat over the years, please keep your tidying constrained to the portion of code or function in which you're patching.

I think there would be no issue in merging the first two commits in this pull request, though.

Ideally we would have dealt with all of the open pull requests some time ago, but it's not always that easy. 😞

@yoshikazusawa
Copy link
Contributor Author

@oalders Thank you for your response and for explaining the notice. I apologize for overlooking that.
I will try to make the adjustments so as not to affect with other PRs.

@oalders
Copy link
Member

oalders commented Oct 30, 2024

I think if you drop 8dc5646 then we can go ahead and merge this. Or I can cherry-pick the commits at the command line. Whatever works for you.

@yoshikazusawa
Copy link
Contributor Author

@oalders Thank you for your advice. I have tried again in #204, so I would appreciate it if you could take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants