Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of rate limit timeout #1045

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

MarkZH
Copy link
Collaborator

@MarkZH MarkZH commented Oct 27, 2024

Type of pull request:

  • Bug fix
  • Feature
  • Other

Description:

Fixes the display of timeouts due to lichess rate limiting.

Related Issues:

Discovered in the lichess discord. Topic link

Checklist:

  • I have read and followed the contribution guidelines.
  • I have added necessary documentation (if applicable).
  • The changes pass all existing tests.

Screenshots/logs (if applicable):

N/A

@MarkZH
Copy link
Collaborator Author

MarkZH commented Oct 27, 2024

Also, we may need to investigate changing this line since the rate limiting warnings in that post may indicate that the maximum number of daily challenges has changed.

@AttackingOrDefending AttackingOrDefending merged commit 36b3a18 into lichess-bot-devs:master Oct 27, 2024
23 checks passed
@AttackingOrDefending
Copy link
Member

Some interesting notes are that on this line, the rate limit for slow games in 200 per day.

Also, this line shows that the rate limits are per IP which can cause problems when running multiple bots.

@MarkZH MarkZH deleted the rate-limit-fix branch October 27, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants