-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: repovation update #225
Conversation
tamtamchik
commented
Oct 2, 2024
•
edited
Loading
edited
- feat: add hardhat task to verify deployed contracts #220
- chore: fix CI permissions #224
Co-authored-by: Eugene Mamin <[email protected]>
feat: add hardhat task to verify deployed contracts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rnmsslido, we have a failing workflow here; I'm surprised that you didn't question this. |
Only change I could review in this PR was on As for the failed workflow, it was related to code coverage and we don't maintain that code (if you need help from us debugging the error, it's another story: you can create a task for us on linear and contact your devops liaison). If the PR isn't ready for review for whatever reason, please mark it as a draft. I'll check #224 shortly. |
chore: testing CI
@rnmsslido roger, thank you for the clarification! 🫡 |
Hardhat Unit Tests Coverage Summary
Diff against master
Results for commit: 5365a63 Minimum allowed coverage is ♻️ This comment has been updated with latest results |