Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LegacyOracle.finalizeUpgrade_V4 can be called multiple times #707

Closed
TheDZhon opened this issue Mar 23, 2023 · 1 comment
Closed

LegacyOracle.finalizeUpgrade_V4 can be called multiple times #707

TheDZhon opened this issue Mar 23, 2023 · 1 comment

Comments

@TheDZhon
Copy link
Contributor

TheDZhon commented Mar 23, 2023 •
edited
Loading

Due to the changed version slot position (from CONTRACT_VERSION_POSITION_DEPRECATED to CONTRACT_VERSION_POSITION), it wasn't checked in the Lido V2 branch (#482) that LegacyOracle.finalizeUpgrade_V4 must not be called more than once.

While the protocol itself doesn't rely on this contract anymore, it could have broken external integrations by changing the time specs stored in the contract.

The issue is resolved in #705

Regression was introduced in 1e643f0
@TheDZhon
Copy link
Contributor Author

Delivered in v2.0.0-rc.0-hotfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheDZhon