Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: finalizeUpgrade_v4 for legacy oracle #705

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Fix: finalizeUpgrade_v4 for legacy oracle #705

merged 2 commits into from
Mar 23, 2023

Conversation

TheDZhon
Copy link
Contributor

@TheDZhon TheDZhon commented Mar 23, 2023 •
edited
Loading

Can't do the following:

  • call finalizeUpgrade_v4 more than once
  • call initialize when the previous deprecated version slot is dirty

Test cases are attached.

Jeday
Jeday approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@Jeday Jeday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

loga4
loga4 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@loga4 loga4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bulbozaur
bulbozaur approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@bulbozaur bulbozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheDZhon TheDZhon mentioned this pull request Mar 23, 2023
Closed
@TheDZhon TheDZhon merged commit d7832e2 into feature/shapella-upgrade Mar 23, 2023
@TheDZhon TheDZhon deleted the fix/oracle-finalizeUpgradeV4 branch March 23, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulbozaur bulbozaur bulbozaur approved these changes

@folkyatina folkyatina folkyatina approved these changes

@loga4 loga4 loga4 approved these changes

@Jeday Jeday Jeday approved these changes

@Psirex Psirex Awaiting requested review from Psirex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheDZhon @bulbozaur @folkyatina @loga4 @Jeday