New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeOperatorsRegistry full unit tests coverage & fixes #488

Merged

Psirex merged 3 commits into staking_router_post_audit_fixes from staking_router_node_operators_registry_tests

Jan 18, 2023

Contributor

Psirex commented Jan 13, 2023 •

edited

Loading

100% coverage by unit tests for the NodeOperatorsRegistry contract.
NodeOperatorsRegistry contract changes:
- fix wrong vetted keys calculation on finalizeUpgrade_v2() for deactivated node operators
- remove extra check that _exitedValidatorsKeysCount >= 0 from unsafeUpdateExitedValidatorsKeysCount()
- remove NodeOperatorUnusedValidatorsKeysTrimmed emitting from the invalidateReadyToDepositKeys() and fix the wrong totalKeysTrimmed argument value in the NodeOperatorTotalKeysTrimmed event
- rework removeSigningKey() to used _removeUnusedSigningKeys() under the hood
- rework removeSigningKeyOperatorBH() to used _removeUnusedSigningKeys() under the hood
- move onlyExistedNodeOperator(_nodeOperatorId) check to the _removeUnusedSigningKeys() method
- get rid of repeated checks and events emitting in the _removeUnusedSigningKey() by moving them into the _removeUnusedSigningKeys()
- add getStETH() method


          NodeOperatorsRegistry full unit tests coverage & fixes

bb4e56c

Psirex changed the base branch from staking_router to staking_router_post_audit_fixes

January 18, 2023 16:29

Psirex added 2 commits

January 18, 2023 20:35


          Add test for requestValidatorsKeysForDeposits global keys counter

f4ac173


          Merge branch 'staking_router_post_audit_fixes' into staking_router_no…

cac9e0c

…de_operators_registry_tests

Psirex merged commit 1184a78 into staking_router_post_audit_fixes

loga4 deleted the staking_router_node_operators_registry_tests branch

January 29, 2023 05:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet