Add methods for batch withdrawals requests and claiming #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
TheDZhon
reviewed
Jan 30, 2023
contracts/0.8.9/WithdrawalQueue.sol
Outdated
| /// @notice Request withdrawal of the provided token amount in a batch | ||
| /// NB: Always reverts | ||
| function requestWithdrawalBatch(uint256[] calldata, address[] calldata) | ||
| struct WithdrawalRequestInput { |
There was a problem hiding this comment.
Is there any drawbacks in reusing these structs in all the methods?
There was a problem hiding this comment.
Or we can even get rid of the singular methods at all. I like this idea more and more.
TheDZhon
reviewed
Jan 30, 2023
Base automatically changed from
feature/wq_review_fixes
to
feature/shapella-upgrade
January 30, 2023 12:14
folkyatina
reviewed
Jan 30, 2023
contracts/0.8.9/WithdrawalQueue.sol
Outdated
| /// @notice Request withdrawal of the provided token amount in a batch | ||
| /// NB: Always reverts | ||
| function requestWithdrawalBatch(uint256[] calldata, address[] calldata) | ||
| struct WithdrawalRequestInput { |
There was a problem hiding this comment.
Is there any drawbacks in reusing these structs in all the methods?
contracts/0.8.9/WithdrawalQueue.sol
Outdated
| /// @notice Request withdrawal of the provided token amount in a batch | ||
| /// NB: Always reverts | ||
| function requestWithdrawalBatch(uint256[] calldata, address[] calldata) | ||
| struct WithdrawalRequestInput { |
There was a problem hiding this comment.
Or we can even get rid of the singular methods at all. I like this idea more and more.
TheDZhon
approved these changes
Jan 31, 2023
folkyatina
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.