test: hash consensus: add more frames tests #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDZhon
approved these changes
Feb 8, 2023
skozin
reviewed
Feb 8, 2023
contracts/0.8.9/test_helpers/oracle/HashConsensusTimeTravellable.sol
Outdated
Show resolved
Hide resolved
| @@ -161,7 +236,7 @@ contract('HashConsensus', ([admin, member1, member2]) => { | |||
| }) | |||
|
|
|||
| it(`decreasing the frame size cannot decrease the current reference slot`, async () => { | |||
| assert.equal(+await consensus.getTime(), computeTimestampAtEpoch(1)) | |||
| assert.equal(+(await consensus.getTime()), computeTimestampAtEpoch(1)) | |||
There was a problem hiding this comment.
could we change prettier settings to not add parentheses around await in cases like this one? it's much less readable this way imo
There was a problem hiding this comment.
Faced same issues with prettier in different PR. My prettier is pulling config from root of the repo but a lot of other files are not formatted at all. In a different PR, we can update config and format all(or just currently relevant) files.
There was a problem hiding this comment.
let's do it later in a single batch I suggest
…o-dao into feature/shapella-upgrade-tests-tests-frames
TheDZhon
approved these changes
Feb 9, 2023
| it('should revert without manage members and qourum role', async () => { | ||
| await assert.reverts(consensus.addMember(member1, 2, { from: account1 }), errorMessage) | ||
| it('should revert without MANAGE_MEMBERS_AND_QUORUM_ROLE role', async () => { | ||
| await assert.revertsOZAccessControl( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests HashConsensus:
fastLaneLengthSlotstogetFrameConfigmethod in hashConsensus contractHashConsensusTimeTravellableINITIAL_EPOCHconst todeployHashConsensus