Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: hashConsensus setQuorum tests #580

Merged
merged 7 commits into from
Feb 9, 2023
Merged

test: hashConsensus setQuorum tests #580

merged 7 commits into from
Feb 9, 2023

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Feb 9, 2023

Tests for setQuorum for basic functionality and its effect during discussion:

  • setQuorum calls are reflected in getQuorum and events
  • setQuorum changes the effective quorum in getConsensusState
  • setQuorum triggers consensus on decrease
  • setQuorum doesn’t re-trigger the same consensus
  • setQuorum doesn’t re-trigger consensus if hash is already being processed

image

@Jeday Jeday requested review from skozin and TheDZhon February 9, 2023 07:11
TheDZhon
TheDZhon approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG 👍

test/0.8.9/oracle/hash-consensus-set-quorum.js Outdated Show resolved Hide resolved
@TheDZhon TheDZhon merged commit 7fe5169 into feature/shapella-upgrade Feb 9, 2023
@TheDZhon TheDZhon deleted the feature/shapella-upgrade-tests-hash-consensus branch February 9, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

@skozin skozin Awaiting requested review from skozin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeday @TheDZhon