Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid transfer to themselves for Withdrawal nft #633

Merged

Conversation

folkyatina
Copy link
Member

No description provided.

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is essential ❤️
Suggested a bit more hardening.

contracts/0.8.9/WithdrawalQueueERC721.sol Outdated Show resolved Hide resolved
Base automatically changed from refactor/nft_renaming to feature/shapella-upgrade-followups February 18, 2023 17:08
@folkyatina folkyatina marked this pull request as draft February 18, 2023 20:40
@folkyatina folkyatina marked this pull request as ready for review February 18, 2023 21:30
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@TheDZhon TheDZhon merged commit c118b21 into feature/shapella-upgrade-followups Feb 19, 2023
@TheDZhon TheDZhon deleted the fix/transfer_to_themselves branch February 19, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants